Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created VYE DGI Service - Reverts #19692 #19696

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Created VYE DGI Service - Reverts #19692 #19696

merged 3 commits into from
Dec 13, 2024

Conversation

RachalCassity
Copy link
Member

Reverts #19692

@RachalCassity RachalCassity requested review from a team as code owners December 3, 2024 22:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

1 Error
🚫 This PR changes 676 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • .github/CODEOWNERS (+4/-1)

  • .rubocop_todo.yml (+1/-0)

  • app/policies/vye_policy.rb (+5/-0)

  • config/initializers/breakers.rb (+2/-0)

  • config/settings.yml (+8/-0)

  • lib/vye/dgib/authentication_token_service.rb (+24/-0)

  • lib/vye/dgib/configuration.rb (+27/-0)

  • lib/vye/dgib/response.rb (+93/-0)

  • lib/vye/dgib/service.rb (+98/-0)

  • modules/vye/app/controllers/vye/application_controller.rb (+0/-1)

  • modules/vye/app/controllers/vye/v1/dgib_verifications_controller.rb (+64/-0)

  • modules/vye/app/serializers/vye/verification_serializer.rb (+7/-7)

  • modules/vye/app/serializers/vye/vye_serializer.rb (+42/-0)

  • modules/vye/config/routes.rb (+4/-0)

  • modules/vye/spec/controllers/vye/v1/dgib_verifications_controller_spec.rb (+99/-0)

  • modules/vye/spec/fixtures/ICA11-RCA2-combined-cert.pem (+34/-0)

  • modules/vye/spec/fixtures/dgi_private_test.pem (+26/-0)

  • modules/vye/spec/fixtures/dgi_public_test.pem (+8/-0)

  • modules/vye/spec/serializers/claimant_verification_serializer_spec.rb (+22/-0)

  • spec/lib/vye/dgib/service_spec.rb (+99/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to revert-19692-revert-19592-rc-vebt-777-revised-draft-pr-2/main/main December 3, 2024 22:57 Inactive
@rjohnson2011
Copy link
Contributor

Just verifying all the manifest certs are in per Trevor's comment -> #19592 (comment)

@bosawt
Copy link
Contributor

bosawt commented Dec 4, 2024

Just verifying all the manifest certs are in per Trevor's comment -> #19592 (comment)

Actually updating my comment, it looks like the cert was defined, but JWT encoding expects a private key. The format used in the fixture here is the correct one, so manifest values need to match this type of file

@RachalCassity
Copy link
Member Author

@bosawt Yes, thank you. I saw that as well. I went ahead and corrected the paths for the team in this PR.

rjohnson2011
rjohnson2011 previously approved these changes Dec 5, 2024
View reviewed changes
@RachalCassity RachalCassity changed the title Revert "Revert "Rc vebt 777 revised - draft PR 2 (#19592)"" BLOCKED - Revert "Revert "Rc vebt 777 revised - draft PR 2 (#19592)"" Dec 5, 2024
@RachalCassity
Copy link
Member Author

Still waiting for the team to get the following parameters added to AWS:

  • sandbox dgib ica11-rca2
  • sandbox dgib jwt
  • sandbox dgib jwt
  • prod dgib ica11-rca2

@RachalCassity RachalCassity changed the title BLOCKED - Revert "Revert "Rc vebt 777 revised - draft PR 2 (#19592)"" Revert "Revert "Rc vebt 777 revised - draft PR 2 (#19592)"" Dec 5, 2024
@RachalCassity RachalCassity changed the title Revert "Revert "Rc vebt 777 revised - draft PR 2 (#19592)"" Created VYE DGI Service Dec 5, 2024
@RachalCassity RachalCassity changed the title Created VYE DGI Service Created VYE DGI Service - Reverts #19692 Dec 5, 2024
@GcioGregg
Copy link
Contributor

I added a fake combined VA cert in modules/vye/spec/fixtures and pointed to that in settings.yml, replacing the empty string.

@va-vfs-bot va-vfs-bot temporarily deployed to revert-19692-revert-19592-rc-vebt-777-revised-draft-pr-2/main/main December 13, 2024 20:32 Inactive
@RachalCassity RachalCassity merged commit 3085f38 into master Dec 13, 2024
28 of 30 checks passed
@RachalCassity RachalCassity deleted the revert-19692-revert-19592-rc-vebt-777-revised-draft-pr-2 branch December 13, 2024 21:34
derekhouck pushed a commit that referenced this pull request Dec 31, 2024
@RachalCassity @GcioGregg @derekhouck
Created VYE DGI Service - Reverts #19692 (#19696)
7cf1fd5 
* Revert "Revert "Rc vebt 777 revised - draft PR 2 (#19592)" (#19692)"

This reverts commit a8981c0.

* add fake combined VA cert

---------

Co-authored-by: GcioGregg <117232882+GcioGregg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GcioGregg GcioGregg GcioGregg approved these changes

@ericboehs ericboehs ericboehs approved these changes

@rjohnson2011 rjohnson2011 rjohnson2011 left review comments

Assignees
No one assigned
Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RachalCassity @rjohnson2011 @bosawt @GcioGregg @ericboehs @va-vfs-bot